Skip to content

Conversation

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented May 11, 2022

What it does

Fixes: #10200.

The pull-request adds support for the LinkedEditingRanges VS Code API including registerLinkedEditingRangeProvider.

linked-editing-support.mp4

How to test

  1. start the application
  2. turn on the preference editor.linkedEditing
  3. open a *.html file
  4. confirm that the language-server correctly starts (doesn't on master)
  5. create a tag
  6. edit the tag - the closing tag should also be updated

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 11, 2022
The commit adds support for the `LinkedEditingRanges` VS Code API
including the provider, and registering the provider with `registerLinkedEditingRangeProvider`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto force-pushed the vf/linked-editing-ranges branch from f371461 to a122fd8 Compare May 11, 2022 18:54
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work as described; the implementation is consistent with other language functionality; the addition to theia.d.ts is consistent with the corresponding API in vscode.d.ts 👍

@vince-fugnitto
Copy link
Member Author

I'll merge tomorrow if there are no objections.

@vince-fugnitto vince-fugnitto merged commit 1265154 into master May 17, 2022
@vince-fugnitto vince-fugnitto deleted the vf/linked-editing-ranges branch May 17, 2022 22:05
@github-actions github-actions bot added this to the 1.26.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vscode issues related to VSCode compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linked editing support

4 participants