core: fix onclick for statusbar items
#11117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
I confirm the bug on master and that this code fixes the problem. Selfishly, I'd request a small change to prevent conflicts with #11083, where I have this code for the same purpose:
} else if (entry.onclick) {
attrs.onClick = e => entry.onclick?.(e.nativeEvent);
}And of course, the removal of the test commit.
The commit fixes an issue when attempting to perform `onclick` for statusbar items. Previously, the `onclick` check we had would not pass and would therefore fail to execute the `onclick` callback. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/fix-statusbar-items
branch
from
c6dd3f5 to
dd87fbf
Compare
colin-grant-work
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11116.
The issue fixes an issue from #10961, where the
onclickcallback did not pass the check we had causing the callback to never execute theonclickhandler.How to test
You can use the test commit (which will be dropped prior to merge):
StatusBar Test- a statusbar item should be contributed to the statusbar (commit c6dd3f5)StatusBar Teststatusbar entryonclickshould work and display a messageReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]