Skip to content

Conversation

@colin-grant-work
Copy link
Contributor

What it does

Fixes #11051 by updating the breaking change notice for files.autoSave.
Also adds a couple of GitHub links to the changelog.

How to test

  1. Assert that the text describing the changes to files.autoSave is clear and accurate, particularly about the removal of the value on.
  2. Assert that the links point to the PR's that they should.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the repo issues specific to the repository label May 5, 2022
@colin-grant-work colin-grant-work force-pushed the minor/changelog-entries branch from 9b70f36 to b139377 Compare May 5, 2022 14:31
@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label May 5, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Sorry for missing those links.

@colin-grant-work colin-grant-work merged commit b6caaf0 into eclipse-theia:master May 5, 2022
@colin-grant-work colin-grant-work deleted the minor/changelog-entries branch May 5, 2022 15:26
@colin-grant-work colin-grant-work added this to the 1.26.0 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation issues related to documentation repo issues specific to the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

files.autoSave doesn't accept "on"

2 participants