re-exports: fix generated eol #10779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the Git configuration of the cloned projects, the EOL might differ from the OS recommended one. On Windows Git might use \n in place of \r\n for example. Implement a small scan to figure out what is the current EOL before generating the re-export files.
paul-marechal
added
OS/Windows
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I'm unable to test on windows, but I confirmed that on macOS and linux that the git index is clean 👍:
┌─[±][mp/fix-gen-eol ✓][theia][]
└─▪ git status
On branch mp/fix-gen-eol
Your branch is up to date with 'origin/mp/fix-gen-eol'.
nothing to commit, working tree clean
vince-fugnitto
approved these changes
Feb 22, 2022
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍
Confirmed it works correctly for mac and linux, and you confirmed locally that it works for windows.
Member
Author
|
@vince-fugnitto thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the Git configuration of the cloned projects, the EOL might
differ from the OS recommended one. On Windows Git might use \n in place
of \r\n for example.
Implement a small scan to figure out what is the current EOL before
generating the re-export files.
Here's an example of what I see with
git statusafter runningyarnon Windows:And Git being the nice guy he his, outputs the following when doing
git add .:In the end this means Git won't count those diffs for real, but it's annoying.
How to test
Running
yarnon Windows should not dirty your Git index anymore.Review checklist
Reminder for reviewers