core: bump socket.io dependency
#10757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit bumps the `socket.io` dependency to a version which does not use `engine.io` at a vulnerable version. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
messaging
paul-marechal
approved these changes
Feb 15, 2022
thegecko
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Feb 17, 2022
The commit bumps the `socket.io` dependency to a version which does not use `engine.io` at a vulnerable version. Signed-off-by: vince-fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10514 (comment).
The commit bumps the
socket.iodependency to a version which does not useengine.ioat a vulnerable version.How to test
yarn audit | grep "engine.io"should not produce any outputReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]