Skip to content

Conversation

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Feb 8, 2022

What it does

The pull-request upgrades electron-rebuild since it was approved by our 'IP Due Diligence' process.

How to test

  • confirm that the electron application builds and starts
  • confirm that yarn rebuild electron and yarn rebuild browser work well

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit upgrades `electron-rebuild` since it was approved by
our 'IP Due Diligence` process.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added electron issues related to the electron target electron-build issues related to building electron dependencies issues that plan to update dependencies labels Feb 8, 2022
@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Feb 8, 2022

Follow-up IP Due Diligence issue:

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vince-fugnitto vince-fugnitto merged commit c74622d into master Feb 10, 2022
@vince-fugnitto vince-fugnitto deleted the vf/electron-rebuild branch February 10, 2022 13:51
@github-actions github-actions bot added this to the 1.23.0 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies issues that plan to update dependencies electron issues related to the electron target electron-build issues related to building electron

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants