Skip to content

"Close Editor" in the File menu did not get the correct translation value #13333

@noneghost

Description

@noneghost

Bug Description:

"Close Editor" in the File menu did not get the correct translation value after use mater branch.

企业微信截图_17066684863542

Steps to Reproduce:

After #13331

registry.registerMenuAction(CommonMenus.FILE_CLOSE, {
commandId: CommonCommands.CLOSE_MAIN_TAB.id,
label: nls.localizeByDefault('Close Editor'),
order: '1'
});

  1. Get "Close Editor" value when use "Close Editor" key, Get right value when use "close Editor" key.
  2. It may be due to a mismatch in the DefaultKey values obtained by nls.

get(defaultValue: string): string | undefined {
const normalized = Localization.normalize(defaultValue);
return this.data.get(normalized) || this.data.get(normalized.toUpperCase());
}

企业微信截图_17066686467715
企业微信截图_17066686828364

Additional Information

  • Theia Version: master branch (commit id: b15b639)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugbugs found in the applicationlocalizationissues related to localization/internalization/nls

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions