Skip to content

Revert broken api #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Conversation

iloveeclipse
Copy link
Member

The two commits in #2200 were merged without proper validation and cause builds to fail due APi errors.

This is a simple revert of #2200.

Copy link
Contributor

Test Results

   545 files  +   441     545 suites  +441   27m 29s ⏱️ + 27m 24s
 4 403 tests + 4 335   4 385 ✅ + 4 317   18 💤 + 18  0 ❌ ±0 
16 733 runs  +16 518  16 593 ✅ +16 378  140 💤 +140  0 ❌ ±0 

Results for commit 47abefa. ± Comparison against base commit 0ebab19.

@iloveeclipse
Copy link
Member Author

Looks like we have more issues in SWT, however they are unrelated to the current change:

Error:  Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.svg: Baseline and reactor have the same fully qualified version, but different content
Error:  different
Error:     META-INF/ECLIPSE_.RSA: not present in baseline
Error:     META-INF/ECLIPSE_.SF: not present in baseline
Error:  -> [Help 1]
Error:  Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.tools.base: Baseline and reactor have the same fully qualified version, but different content
Error:  different
Error:     META-INF/ECLIPSE_.RSA: not present in baseline
Error:     META-INF/ECLIPSE_.SF: not present in baseline
Error:  -> [Help 1]
Error:  Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.examples.views: Baseline and reactor have the same fully qualified version, but different content
Error:  different
Error:     META-INF/ECLIPSE_.RSA: not present in baseline
Error:     META-INF/ECLIPSE_.SF: not present in baseline
Error:  -> [Help 1]
Error:  Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.examples.browser.demos: Baseline and reactor have the same fully qualified version, but different content
Error:  different
Error:     META-INF/ECLIPSE_.RSA: not present in baseline
Error:     META-INF/ECLIPSE_.SF: not present in baseline
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :org.eclipse.swt.svg
Error: Process returned exit code 1

@akurtakov
Copy link
Member

This is usually fixed by cleaning the caches at https://github.com/eclipse-platform/eclipse.platform.swt/actions/caches . Unfortunately, I have no clue what more could be done to not fail.

@iloveeclipse iloveeclipse merged commit 8202faf into eclipse-platform:master Jun 25, 2025
19 of 20 checks passed
@iloveeclipse iloveeclipse deleted the revert_broken_API branch June 25, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants