Skip to content

[GTK] Simplify Tree/Table #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

[GTK] Simplify Tree/Table #2100

merged 1 commit into from
May 5, 2025

Conversation

akurtakov
Copy link
Member

This is continuation of
#2059 . There is no point in having these extra methods (and double checkWidget method calls for so many things).

@akurtakov
[GTK] Simplify Tree/Table
b421226 
This is continuation of
eclipse-platform#2059 .
There is no point in having these extra methods (and double checkWidget
method calls for so many things).
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Test Results

   539 files   -  6     539 suites   - 6   36m 9s ⏱️ + 5m 34s
 4 339 tests  - 37   4 322 ✅  - 36   15 💤  - 3  2 ❌ +2 
16 606 runs   - 37  16 467 ✅  - 36  137 💤  - 3  2 ❌ +2 

For more details on these failures, see this check.

Results for commit b421226. ± Comparison against base commit 195a3bf.

This pull request removes 37 tests. 
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

@akurtakov
Copy link
Member Author

Failing Windows tests are unrelated to pure GTK changes. Merging.

@akurtakov akurtakov merged commit af044d9 into eclipse-platform:master May 5, 2025
15 of 17 checks passed
@github-project-automation github-project-automation bot moved this to Done in SWT work May 5, 2025
akurtakov added a commit to akurtakov/eclipse.platform.swt that referenced this pull request May 5, 2025
@akurtakov
[GTK] Remove more *InPixels method
cd1d9ac 
They are not needed at all, double some calls (like checkWidget()), and
overall complicate debugging and understanding the codebase.
Continuation of
eclipse-platform#2100
@akurtakov akurtakov mentioned this pull request May 5, 2025
Merged
akurtakov added a commit that referenced this pull request May 5, 2025
@akurtakov
[GTK] Remove more *InPixels method
d1859ce 
They are not needed at all, double some calls (like checkWidget()), and
overall complicate debugging and understanding the codebase.
Continuation of
#2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akurtakov