Fix OnServerDisconnect not being called when packet has no properties #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue would occur if the broker does not insert a zero for the properties length. Fixes: eclipse-paho#302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue would occur if the broker does not insert a zero for the properties length.
Please provide enough information so that others can review your pull request:
Testing
Tested against a mosquitto plugin that kicks clients. This sends the client a packet with the fixed header, a message len of 1, and a reason code, but no props length (allowed by MQTT v5 spec). Validated that with changes, OnServerDisconnect is called.
Added a test to replicate this scenario.
Closing issues
closes #302