Skip to content

Remove deprecated DestType.DEST_FLAVOR_FAILOVER #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dtpp
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* <pre>
* 1. Its type (Queue or Topic)
* 2. Its lifespan (temporary or not)
* 3. Its flavor (single, round robin, failover, etc)
* 3. Its flavor (single, round robin, etc)
* </pre>
*
* In practice all combinations are not used (for example you don't have round-robin topics), but by using bitmaps we
Expand Down Expand Up @@ -70,12 +70,6 @@ public class DestType {
@Deprecated
public static final int DEST_FLAVOR_RROBIN = 0x00000200;

/**
* @deprecated since 3.5
*/
@Deprecated
public static final int DEST_FLAVOR_FAILOVER = 0x00000400;

/**
* Internal destination name prefix
*
Expand Down Expand Up @@ -198,14 +192,6 @@ public static boolean isRRobin(int mask) {
return (mask & DEST_FLAVOR_RROBIN) == DEST_FLAVOR_RROBIN;
}

/**
* @deprecated since 3.5
*/
@Deprecated
public static boolean isFailover(int mask) {
return (mask & DEST_FLAVOR_FAILOVER) == DEST_FLAVOR_FAILOVER;
}

public static String toString(int mask) {
StringBuilder s = new StringBuilder();

Expand Down Expand Up @@ -237,8 +223,6 @@ public static String toString(int mask) {
s.append(":single");
} else if (isRRobin(mask)) {
s.append(":roundrobin");
} else if (isFailover(mask)) {
s.append(":failover");
}

return s.toString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class toString {
"129, queue:admin",
"257, queue:single",
"513, queue:roundrobin",
"1025, queue:failover",
"1025, queue",
"8193, queue:local",
"8241, queue:temporary:autocreated:local",
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ public String toString() {
* Queue flavour property values
*/
String PROP_VALUE_QUEUE_FLAVOUR_SINGLE = "s";
String PROP_VALUE_QUEUE_FLAVOUR_FAILOVER = "f";
String PROP_VALUE_QUEUE_FLAVOUR_ROUNDROBIN = "r";

/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@
* imq.autocreate.queue.maxNumBackupConsumers=0
*
* // default queue delivery policy (for auto-create queues) // Choices are: // single - standard single queue receiver
* queues // failover - failover // round-robin
* queues // round-robin
*
* // defines the number of messages queued at a time to a receiver // on a round robin queue
* imq.queue.rr.messageblock=5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,6 @@ private void setDefaultCounts(int type, boolean autocreate) throws BrokerExcepti
if (DestType.isSingle(type)) {
active = 1;
failover = 0;
} else if (DestType.isFailover(type)) {
active = 1;
failover = UNLIMITED;
} else if (DestType.isRRobin(type)) {
active = UNLIMITED;
failover = 0;
Expand Down