Skip to content

Call CompletionCallback just once with DefaultExceptionMapper #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

Call CompletionCallback just once with DefaultExceptionMapper #5077

merged 1 commit into from
Jun 8, 2022

Conversation

jansupol
Copy link
Contributor

@jansupol jansupol commented Jun 8, 2022

Do not propagate error to the client

Signed-off-by: jansupol [email protected]

@jansupol
Call CompletionCallback just once with DefaultExceptionMapper
6885c03 
Do not propagate error to the client

Signed-off-by: jansupol <[email protected]>
@jansupol jansupol linked an issue Jun 8, 2022 that may be closed by this pull request
Version 3.1.0-M5 was the last version passing the TCK with GlassFish #5072
Closed
@jansupol jansupol mentioned this pull request Jun 8, 2022
Closed
@jansupol jansupol merged commit abd1a43 into eclipse-ee4j:3.1 Jun 8, 2022
@jansupol jansupol deleted the CompletionCallbackWithExceptionMapperFix branch June 8, 2022 15:28
@dmatej
Copy link
Contributor

dmatej commented Jun 8, 2022

I can confirm that this fixed jaxrs tck tests for GlassFish:

[runcts] OUT => [javatest.batch] Jun 8, 2022, 6:11:44 PM Harness done with cleanup from test run.
[runcts] OUT => [javatest.batch] Total time = 469s
[runcts] OUT => [javatest.batch] Setup time = 0s
[runcts] OUT => [javatest.batch] Cleanup time = 2s
[runcts] OUT => [javatest.batch] Test results: passed: 138

@jansupol jansupol added this to the 3.1.0 milestone Jun 9, 2022
This was referenced Nov 4, 2022
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Nov 20, 2022
Open
Closed
Open
Open
Open
Open
@janhoy janhoy mentioned this pull request Nov 30, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Dec 7, 2022
Closed
1 task
This was referenced Dec 17, 2022
Closed
Closed
Closed
@solrbot solrbot mentioned this pull request Jan 22, 2024
Closed
1 task
@renovate-bot renovate-bot mentioned this pull request Feb 26, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Mar 18, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Apr 5, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Apr 19, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request May 24, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Jun 28, 2024
Merged
1 task
This was referenced Jul 9, 2024
Open
Merged
Closed
@solrbot solrbot mentioned this pull request Jul 22, 2024
Closed
1 task
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Aug 2, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Oct 8, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 8, 2025
Closed
1 task
@solrbot solrbot mentioned this pull request Jan 9, 2025
Closed
1 task
@renovate-bot renovate-bot mentioned this pull request Jan 11, 2025
Merged
1 task
@solrbot solrbot mentioned this pull request Jan 25, 2025
Open
1 task
This was referenced Jan 30, 2025
Merged
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Mar 10, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Mar 24, 2025
Closed
1 task
This was referenced May 26, 2025
Closed
Closed
Open
Open
@renovate renovate bot mentioned this pull request Aug 8, 2025
Closed
1 task
@solrbot solrbot mentioned this pull request Aug 29, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Version 3.1.0-M5 was the last version passing the TCK with GlassFish
3 participants
@jansupol @dmatej @senivam