Save flash/RAM, replace unused tUSB with stubs #3272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Replace the specific device callbacks with weak stubs unless the application actually uses a library which needs it. MSC_Device saves 2136b flash, 128b RAM MIDI_Device saves 680b flash, 328b RAM HID_Device saves 816b flash, 408b RAM In total 3.6K flash and 850b RAM. Apps which manually try and build their own usage of the low-level TinyUSB code need to include the appropriate <tusb-xxx.h> file.
earlephilhower
force-pushed
the
automat
branch
from
ab5dc4d to
47d4a78
Compare
Draft
Will speed up FatFSUSB and SingleFileDrive without causing memory pressure for apps not using MSD.
There is what seems to be a known race condition in TinyUSB on the Pico, see hathach/tinyusb#1764 . Delay text output a little bit after the MSD is started to avoid.
Owner
Author
|
All tests seem to pass now (and Joystick is unbusted!) HID
MIDI
MSD
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the specific device callbacks with weak stubs unless the application actually uses a library which needs it.
MSC_Device saves 2136b flash, 128b RAM
MIDI_Device saves 680b flash, 328b RAM
HID_Device saves 816b flash, 408b RAM
In total 3.6K flash and 850b RAM.
Apps which manually try and build their own usage of the low-level TinyUSB code need to include the appropriate <tusb-xxx.h> file.