Add Tutorials to optional dependencies and update tutorial workflow.#2869
Add Tutorials to optional dependencies and update tutorial workflow.#2869KS-HTK merged 21 commits intoe2nIEE:developfrom
Conversation
|
I would suggest creating a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2869 +/- ##
===========================================
- Coverage 72.03% 72.02% -0.01%
===========================================
Files 351 351
Lines 37506 37506
===========================================
- Hits 27016 27014 -2
- Misses 10490 10492 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
interesting point, we had this in the past, and changed it to the current version. |
|
@KS-HTK please check. the test is still failing. |
|
Adding a set for the tutorials is fine, but I would suggest that it covers the basics and if one is doing tutorials for say There are multiple arguments to be made to support this:
In my opinion the all set should be for all dependencies of the package not the repository, and we should even remove |
Yes agreed, We can restrict tutorial set to minimum dependencies required for tutorials only. |
What about docs and typing sets? |
Updated the Python version for the 'uv' installation and uncommented relevant steps in the GitHub Actions workflow.
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Updated Python version from 3.14 to 3.13 in GitHub Actions workflow.
Updated Python version from 3.13 to 3.12 in GitHub Actions workflow.
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
e75c919 to
18550d1
Compare
No, I would suggest adding them to the dev set and keeping them out from all. As I understand it typing should only ever be checked by mypy locally or in the pipelines and not at runtime and docs cannot be built from the package as it does not contain the files required. A dev set is a great Idea, it would also make installation in the pipeline easier. |
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
|



Currently dependencies related to tutorials are not included in project.toml, which results in
uv sync --all-extrasremoving these dependencies. With tutorial dependencies,uv sync --all-extraswill enable tutorials.Moreover, updated Tutorial test workflows to align with other workflows using
uv.As mentioned in #2868 , the tutorial tests fail on Python 3.13 and Python 3.14.
Currently tutorial workflow do not specify python version, and as per following the pre-installed python version in ubuntu-latest is Python 3.12.3.
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#language-and-runtime
However, if github updates this in future, tutorial tests will fail. Unless the issues with Julia/ pandamodels is fixed, the tutorial test workflow must specify python version, restricting to Python 3.12.