Fix Convert_CRS

[furqan463]

Fixes Issue #2761
Currently convert_crs fails if coordinates are present in either bus or line but not both.
Inside abstract_convert_crs it checks if geo attribute is present in both bus and line and if either of them does not contain geo attribute, the program tries to access bus_geo_data and line_goe_data and a key error is raised as both these attributes may not be present if network is constructed using latest create_bus and create_line.

[furqan463]

The first commit just reproduces the error by adding tests.
Once the issue is resolved, these tests will pass.

[furqan463]

@KS-HTK need to your help here.
This will surely fix in cases where bus or line has geo attribute, or otherwise if bus_geo_data is present in network. but I'm not sure in the case when line.geo is not present but line_geo_data is present in net. as I've merged 'geo_branch_transformer' into 'geo_node_transformer' with a check isinstance(r, list).
I hope it'll work but I'm not sure.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.88%. Comparing base (d0c4c6e) to head (6073df4).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2764      +/-   ##
===========================================
+ Coverage    74.77%   74.88%   +0.11%     
===========================================
  Files          315      315              
  Lines        36327    36329       +2     
===========================================
+ Hits         27164    27206      +42     
+ Misses        9163     9123      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[furqan463]

@KS-HTK I've added tests for geodata as well, so now I think it's good to go. Please review it.
@vogt31337

[KS-HTK]

This is a very good improvement. But it seems that I could identify an error.
Thank you for the pr!

[furqan463]

Please review again.

[KS-HTK]

To keep pull requests clean please do not add changes to a pull request that are not related.

We are already aware of the missing version header in the Changelog. But this change must also be pushed to the release branch and therefore requires a hotfix.

The incorrect version number in the pipeline is a required change we missed while dropping support for python 3.9. This was mostly missed as we do not require (and currently do not expect) these pipelines to succeed. In my opinion it can remain here but in the future it would be better suited for its own PR.

[furqan463]

To keep pull requests clean please do not add changes to a pull request that are not related.

We are already aware of the missing version header in the Changelog. But this change must also be pushed to the release branch and therefore requires a hotfix.

The incorrect version number in the pipeline is a required change we missed while dropping support for python 3.9. This was mostly missed as we do not require (and currently do not expect) these pipelines to succeed. In my opinion it can remain here but in the future it would be better suited for its own PR.

sure.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud