Skip to content

REFACTOR: Remove getType() override to allow extensibility #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsirish merged 2 commits into from
Dec 2, 2025
Merged

REFACTOR: Remove getType() override to allow extensibility #14

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d89aeca
REFACTOR: Remove getType() override to allow extensibility
jsirish Dec 2, 2025
c8bfa1d
FIX: Add $singular_name and $plural_name to ElementCarousel
jsirish Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Elements/ElementCarousel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,4 @@ protected function provideBlockSchema()
$blockSchema['content'] = $this->getSummary();
return $blockSchema;
}

/**
* @return string
*/
public function getType()
{
return _t(__CLASS__ . '.BlockType', 'Carousel');
}
}
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing getType() without adding private static $singular_name = 'Carousel'; to the class will break backward compatibility. Without $singular_name, BaseElement::getType() will fall back to 'Block' as the default display name instead of 'Carousel'.

Additionally, the test testGetType() in tests/Elements/ElementCarouselTest.php (line 38-42) expects getType() to return 'Carousel' and will fail after this change unless updated.

Copilot uses AI. Check for mistakes.
Loading