Added failed test #78
Conversation
|
The added test is totally the same like first one with only one difference - in a first line I instantiate |
|
@ajgarlag is that releated to your changes maybe? 😊 |
|
Surely! I think this is related to symfony/symfony#28544. @CvekCoding Can you try to revert a8c3c0a and tell us if it works? |
|
@ajgarlag yes, this helped, thanks. I'll continue my investigations. |
| @@ -5,10 +5,20 @@ | |||
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
|
|
|||
| <services> | |||
| <service id="dunglas_doctrine_json_odm.normalizer.raw_object" class="Symfony\Component\Serializer\Normalizer\ObjectNormalizer" public="false"> | |||
There was a problem hiding this comment.
| <service id="dunglas_doctrine_json_odm.normalizer.raw_object" class="Symfony\Component\Serializer\Normalizer\ObjectNormalizer" public="false"> | |
| <service id="dunglas_doctrine_json_odm.normalizer.object" class="Symfony\Component\Serializer\Normalizer\ObjectNormalizer" public="false"> |
| <argument type="service" id="serializer.denormalizer.array" /> | ||
| <argument type="service" id="serializer.normalizer.object" /> | ||
| <argument type="service" id="dunglas_doctrine_json_odm.normalizer.array" /> | ||
| <argument type="service" id="dunglas_doctrine_json_odm.normalizer.raw_object" /> |
There was a problem hiding this comment.
| <argument type="service" id="dunglas_doctrine_json_odm.normalizer.raw_object" /> | |
| <argument type="service" id="dunglas_doctrine_json_odm.normalizer.object" /> |
|
Can I ask you to fix the CS issues? Thank you! |
Done |
|
Added a few important notes here https://github.com/dunglas/doctrine-json-odm/pull/74/files |
|
Since there is only a conflict in the README.md, could anyone fix this and merge this pull? |
|
@Toflar I think this this PR should be merged and tagged as rc2. The README changes should be applied too. |
|
Thank you @CvekCoding and @ajgarlag! I've also tagged rc2! Sorry folks that it took so long! |
|
As promised: Version 1.0.0 stable is here! Thanks to everyone involved! You may now update your Composer requirements and require the stable version 😎 |
I have added a test which shows my issue - if you (or DI) instantiate basic symfony serializer, it invokes
setSerializermethod of allSerializerAwareservices and rewritesserializerproperty fromDunglasSerializertoSymfobySerializer.This breaks the further normalization.