Skip to content

Add a note about DateTimeNormalizer in README #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2023
Merged

Add a note about DateTimeNormalizer in README #119

merged 3 commits into from
Feb 23, 2023

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Sep 13, 2022

Without it, serializing DateTimeInterface instances leads to huge serialized data.

@dunglas
Copy link
Owner

dunglas commented Feb 2, 2023

Good idea, but then we should also register the DateTimeNormalizer in the Symfony bundle for consistency: https://github.com/dunglas/doctrine-json-odm/blob/main/src/Bundle/Resources/config/services.xml#L23

Could you add this to this PR? Thanks.

@mlocati
Copy link
Contributor Author

mlocati commented Feb 18, 2023

@dunglas Do you mean something like d36fd32 ?

@mlocati @dunglas
Add a note about DateTimeNormalizer in README
ba01690 
Without it, serializing DateTimeInterface instances leads to huge serialized data.
@mlocati @dunglas
Register the DateTimeNormalizer in the Symfony bundle
c176522
@dunglas dunglas force-pushed the patch-1 branch 2 times, most recently from 93cba21 to 8acf02c Compare February 23, 2023 15:17
@dunglas dunglas merged commit d729dc3 into dunglas:main Feb 23, 2023
@mlocati mlocati deleted the patch-1 branch February 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlocati @dunglas