Skip to content

Conversation

Egor-Krivov
Copy link

This PR enables modin backend, which was part of the original H2O benchmark. If something is missing don't hesitate to contact me to fix the issue.

Copy link

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, thanks for updating.

@Tmonster
Copy link
Collaborator

Thanks for the PR!
In order to update the report I ask authors to run the benchmark themselves on a c6id.metal and report the updates to the time.csv and logs.csv files as well. In order to make sure everything works as is though, you can wait until the regression tests pass.

Can you also add modin to the solution-matrix in the regression.yml file? That way it will get automatically tested

@Egor-Krivov
Copy link
Author

Thanks for the PR! In order to update the report I ask authors to run the benchmark themselves on a c6id.metal and report the updates to the time.csv and logs.csv files as well. In order to make sure everything works as is though, you can wait until the regression tests pass.

Can you also add modin to the solution-matrix in the regression.yml file? That way it will get automatically tested

Hi, I added modin to the regression matrix.

I will run it on c6id.metal later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants