fix(opfs): add auto OPFS file registration & update dropFiles method #1945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Auto File Registration:
When AsyncDuckDB#runQuery or startPendingQuery includes an opfs:// file path, the function automatically calls AsyncDuckDB#registerFileHandler.
dropFiles Method Updates:
Rationale
Testing
Impact
autoFileRegistration
will not see any change in behavior regarding file registration.dropFiles
originally did not accept arguments, existing calls using no arguments remain unaffected.However, if any code previously passed arguments (intentionally or unintentionally), the behavior might now differ because those arguments will be processed instead of ignored.