Make result set getColumn by name case insensitive. Add test for same. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, along with tablename.
Mause
requested changes
Jun 25, 2024
|
Hi @Mause, since i run into this bug: which other class did you mean? Or are there other reasons it won't get merged? |
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Apr 3, 2025
This change brings in the duckdb#43 PR with additional changes to the `Array` result set requested by the reviewer in duckdb#43. For the `Array` result set the column names `INDEX` and `VALUE` are taken from the implementation in Postgres' `pgjdbc` driver. Testing: test from duckdb#43 is included, test for `Array` result set is enhanced with additional checks. Fixes: duckdb#40 Co-authored-by: jghoman <[email protected]>
|
Thanks for the PR! I've included it as-is into #185 also adding there the requested changes to the I wonder if you would like to take a look at the changes to DuckDBArrayResultSet (as the original author of this bit)? The changes there are mostly mechanical, but one change of |
|
The changes from this PR were included into #185 PR, closing this PR as superseded. |
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Apr 7, 2025
This change brings in the duckdb#43 PR with additional changes to the `Array` result set requested by the reviewer in duckdb#43. For the `Array` result set the column names `INDEX` and `VALUE` are taken from the implementation in Postgres' `pgjdbc` driver. Testing: test from duckdb#43 is included, test for `Array` result set is enhanced with additional checks. Fixes: duckdb#40 Co-authored-by: jghoman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40 . Adds unit test both for column names from resultset as well as tablename itself, since we're already there.
This uses
equalsIgnoreCaserather than the previous `contentEquals,' which is ever so slightly different (String to String versus String to CharSequence/String/StringBuffer, respectively), but I think that shouldn't make a difference in these use cases.