Fix executeBatch in auto-commit mode (1.3) #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of the PR duckdb#261 to `v1.3-ossivalis` stable branch. This change fixes the problem when connection is left in inconsistent state when `executeBatch` throws constraint (or some other) error with auto-commit enabled. In duckdb#213 `executeBatch` was changed to effectively disable auto-commit for the whole batch. In this case the rollback on error needs to be handled inside `executeBatch` too. Testing: new tests added that cover constrain violation with `executeBatch`. Fixes: duckdb#259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the PR #261 to
v1.3-ossivalisstable branch.This change fixes the problem when connection is left in inconsistent state when
executeBatchthrows constraint (or some other) error with auto-commit enabled.In #213
executeBatchwas changed to effectively disable auto-commit for the whole batch. In this case the rollback on error needs to be handled insideexecuteBatchtoo.Testing: new tests added that cover constrain violation with
executeBatch.Fixes: #259