Add support for query timeouts #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arouel
reviewed
Jun 3, 2025
| @@ -20,6 +21,8 @@ public class DuckDBDriver implements java.sql.Driver { | |||
| static final String DUCKDB_URL_PREFIX = "jdbc:duckdb:"; | |||
| static final String MEMORY_DB = ":memory:"; | |||
|
|
|||
| static final ScheduledThreadPoolExecutor scheduler = new ScheduledThreadPoolExecutor(1); | |||
There was a problem hiding this comment.
It would be helpful when the thread name has a meaningful name. We could achieve this by using a ThreadFactory as second argument to set the name a new thread is created.
There was a problem hiding this comment.
Thanks for the review! Good idea, updated the PR to add this.
staticlibs
force-pushed
the
query_timeout
branch
4 times, most recently
from
cbfa8ff to
fdd9a47
Compare
This change implements `Statement#setQueryTimeout()` method. It is implemented by scheduling a background task and calling `Statement#cancel()` when timeout expires. Timeouted statement has the same behaviour as it would be if cancelled manually - `SQLException` is thrown and the statement is closed. Timeout is applied for all `execute*` calls. For `executeBatch()` it is applied separately for every single query in a batch. Testing: new test added. Fixes: duckdb#212
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jun 6, 2025
This change restores the contents of duckdb#250 that were inadvertently removed in duckdb#247.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jun 6, 2025
This change restores the contents of duckdb#250 that were inadvertently removed in duckdb#247.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Jun 15, 2025
This is a backport of the PR duckdb#247 to `v1.3-ossivalis` stable branch. This change implements `Statement#setQueryTimeout()` method. It is implemented by scheduling a background task and calling `Statement#cancel()` when timeout expires. Timeouted statement has the same behaviour as it would be if cancelled manually - `SQLException` is thrown and the statement is closed. Timeout is applied for all `execute*` calls. For `executeBatch()` it is applied separately for every single query in a batch. Testing: new test added. Fixes: duckdb#212
staticlibs
added a commit
that referenced
this pull request
Jun 15, 2025
This is a backport of the PR #247 to `v1.3-ossivalis` stable branch. This change implements `Statement#setQueryTimeout()` method. It is implemented by scheduling a background task and calling `Statement#cancel()` when timeout expires. Timeouted statement has the same behaviour as it would be if cancelled manually - `SQLException` is thrown and the statement is closed. Timeout is applied for all `execute*` calls. For `executeBatch()` it is applied separately for every single query in a batch. Testing: new test added. Fixes: #212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements
Statement#setQueryTimeout()method. It is implemented by scheduling a background task and callingStatement#cancel()when timeout expires.Timeouted statement has the same behaviour as it would be if cancelled manually -
SQLExceptionis thrown and the statement is closed.Timeout is applied for all
execute*calls. ForexecuteBatch()it is applied separately for every single query in a batch.Testing: new test added.
Fixes: #212