Result set enhancements for integer types #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves support for integer types in `ResultSet`. It allows to fetch more narrow types (like `SMALLINT`) using `getObject()` calls with more wide type parameter (like `BIGINT`). It also adds support for fethching `HUGEINT` values as instances of a `BigInteger` class and adds new methods to `Connection` to be able to insert 128-bit `HUGEINT` values passing them as a pair of `long`'s or as a `BigInteger`. Additonally it corrects JDBC types mapping for integer types and changes the fallback JDBC type from `JAVA_OBJECT` to `OTHER`. Testing: new tests are added to cover integer values fetching from `ResultSet`; existing `ResultSet` tests moved to separate files. Fixes: duckdb#204
staticlibs
force-pushed
the
resultset_int_types
branch
from
be215e7 to
b517d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves support for integer types in
ResultSet. It allows to fetch more narrow types (likeSMALLINT) usinggetObject()calls with more wide type parameter (likeBIGINT).It also adds support for fethching
HUGEINTvalues as instances of aBigIntegerclass and adds new methods toConnectionto be able to insert 128-bitHUGEINTvalues passing them as a pair oflong's or as aBigInteger.Additonally it corrects JDBC types mapping for integer types and changes the fallback JDBC type from
JAVA_OBJECTtoOTHER.Testing: new tests are added to cover integer values fetching from
ResultSet; existingResultSettests moved to separate files.Fixes: #204