Support typed configuration options #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticlibs
force-pushed
the
typed_config
branch
from
2b5aae0 to
191b649
Compare
This change adds support for all primitive types (and additionally for a list of strings) for configuration values that can be passed to `DriverManager.getConnection(url, conf)`. To be able to handle config in a separate compilation unit, cached references and common utilities are moved to separate files. There are a few more check added to the Java references collection code, but it still kept largely the same. Additionally the `file_system` field of the `DBConfig` is filled manually, it was necessary because this field is used for checks when incoming file-system related options are set. Testing: new test added that sets typed config values and checks that they are set with `current_setting()`. Fixes: duckdb#137
staticlibs
force-pushed
the
typed_config
branch
from
191b649 to
3e688d2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for all primitive types (and additionally for a list of strings) for configuration values that can be passed to
DriverManager.getConnection(url, conf).To be able to handle config in a separate compilation unit, cached references and common utilities are moved to separate files. There are a few more check added to the Java references collection code, but it still kept largely the same.
Additionally the
file_systemfield of theDBConfigis filled manually, it was necessary because this field is used for checks when incoming file-system related options are set.Testing: new test added that sets typed config values and checks that they are set with
current_setting().Fixes: #137