Documenting CA certificates setup for hetty#21
Conversation
|
I just went through this process myself getting a local dev environment up and saw the note in the README, so I figured I would include some documentation. This was only tested on Linux, but I included instructions for Ubuntu, macOS, and Windows by referencing various guides. I hope they're helpful 👍 |
- Provides more accessible instructions on CA certificates - New sections provided for "Certificate Setup and Installation" - Configuring certificates for hetty using defaults and direct CLI arguments - Trusting CA certificates on Windows, macOS, and Ubuntu - Mention for additional Linux distros not covered by Ubuntu Ref: dstotijn#12
2f1b64b to
461a153
Compare
…oth Hetty and OpenSSL
dstotijn
left a comment
There was a problem hiding this comment.
Thanks for taking the effort @tcarrio! Left a few comments, but in general I think this is a good start. We'll probably refactor the certificate instructions into a separate docs site, but for now I think the README is the best place.
|
You should consider building on, or using, mkcert: https://github.com/FiloSottile/mkcert It automates the installation of the CA on major OS’ and is well-tested. |
Co-authored-by: David Stotijn <dstotijn@gmail.com>
|
All of the comments look valid. I'll be applying all of them, which I can't seem to batch as a single commit in the GitHub UI. I will apply the updates and push again next chance. |
Co-authored-by: David Stotijn <dstotijn@gmail.com>
…irrelevant or misleading
|
This has been updated according to review. Please let me know what else may need updating 👍 |
I also completely agree that we should employ the concept of doing 1 thing, but doing it really good. makign / managing a CA should be out of scope for Hetty... but it could include instructions / inclusion of mkcert for that purpose. As to the instructions using mkcert: github.com/FiloSottile/mkcert
I hope that helps, and if you like I am willign to also add it to the readme in a PR (after this one is accepted). |
| will cover how you can generate your certificate, provide them to hetty, and how | ||
| you can install them in your local CA store. | ||
|
|
||
| ⚠️ _This process was done on a Linux machine but should_ |
There was a problem hiding this comment.
I wonder if this should be native markdown :warning: instead of an embedded emoji
@Lawri-van-Buel: I think the way forward is to use mkcert as a library (import/dependency) in Hetty, at least for installing a CA in a system/browser CA store. That way we can leverage mkcert's features for CA management without introducing a lot (arguably non-core) code in Hetty. The alternative of instructing users to manually download/use For now, generating the CA keypair ourselves and instructing users to install to their system/browser CA store is fine, and leading up to an eventual v1.0 release we can work on embedding mkcert. I'll create a separate issue for this in due time, but if you want to work on it already or discuss/how to do it, that'd be much appreciated! Probably discussions would be the best place. |
arguments
Ref: #12