Skip to content

Conversation

@ariebovenberg
Copy link
Contributor

I have made things!

slotscheck will become more strict about import paths in the future. I'm changing the invocation here to ensure slotscheck runs on the files, not the installed package. Running with python -m ensures the current working directory is in sys.path so the correct files are imported.

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made n/a
  • I have updated the documentation for the changes I have made n/a
  • I have added my changes to the CHANGELOG.md n/a

Related issues

#1233

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1265 (4e654fe) into master (1630e06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         2434      2434           
  Branches       211       211           
=========================================
  Hits          2434      2434           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1630e06...4e654fe. Read the comment docs.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress with slotscheck! Thanks!

@sobolevn sobolevn merged commit 74bdae9 into dry-python:master Feb 2, 2022
@ariebovenberg ariebovenberg deleted the update-slotscheck branch February 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants