Skip to content

Support file_entity metadata for width/height #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.x-4.x
Choose a base branch
from
Open

Support file_entity metadata for width/height #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Plugin/GraphQL/DataProducer/Entity/Fields/Image/ImageDerivative.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Drupal\Core\Render\RenderContext;
use Drupal\Core\Render\RendererInterface;
use Drupal\file\FileInterface;
use Drupal\file_entity\FileEntityInterface;
use Drupal\graphql\Plugin\GraphQL\DataProducer\DataProducerPluginBase;
use Drupal\image\Entity\ImageStyle;
use Symfony\Component\DependencyInjection\ContainerInterface;
Expand Down Expand Up @@ -100,6 +101,15 @@ public function resolve(FileInterface $entity = NULL, $style, RefinableCacheable

$width = $entity->width;
$height = $entity->height;
// Optionally support the extra data from file_entity.
if ($entity instanceof FileEntityInterface) {
if (empty($width)) {
$width = $entity->getMetadata('width');
}
if (empty($height)) {
$height = $entity->getMetadata('height');
}
}

// @todo Not sure why PHPStan complains here, this should be refactored to
// check the entity properties first.
Expand Down