Support for slackUserIdFromEmail slackUserIdsFromCommitters commands #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done Co-authored-by: OP (oppenheimer) <[email protected]>
Ompragash
requested changes
Nov 27, 2024
Ompragash
requested changes
Nov 27, 2024
Ompragash
requested changes
Dec 4, 2024
Ompragash
requested changes
Dec 5, 2024
Member
Ompragash
left a comment
Ompragash
left a comment
There was a problem hiding this comment.
As discussed, please ensure to test the windows variant of the plugin image in Harness CI with the same steps as in Linux stage
also, add tests for the newly added functions for below cases:
- repositories with no commits or committers without emails
- slack user lookup failures or rate-limiting
Ompragash
reviewed
Dec 6, 2024
Member
Ompragash
left a comment
Ompragash
left a comment
There was a problem hiding this comment.
added some minor review - rest looks good
Co-authored-by: OP (oppenheimer) <[email protected]>
Co-authored-by: OP (oppenheimer) <[email protected]>
Co-authored-by: OP (oppenheimer) <[email protected]>
Co-authored-by: OP (oppenheimer) <[email protected]>
Ompragash
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting following functionalities
slackUserIdFromEmail
slackUserIdsFromCommitters
Pipeline execution link
https://app.harness.io/ng/account/gCoPSwHxS7ipOgx2iA9tOQ/all/orgs/default/projects/jenkinstoharness/pipelines/slack_commiters_list_senthil_05/executions/5emdUnSlTKmz5jRRNC-9gA/pipeline?storeType=INLINE&step=jkR0R4-aTb2LlVCVzS7lIQ&stage=oke94MPXS_SVKrvQvAqijQ&childStage=&stageExecId=