fix: [CI-19828] Throw error instead of warning in case of directory u… #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ompragash
requested changes
Dec 29, 2025
Comment on lines
431
to
436
| if count <= 1 { | ||
| log.Warnf("Skipping '%s' since it is a directory. Please use correct glob expression if this is unexpected.", source) | ||
| return fmt.Errorf("directory '%s' specified without glob pattern. Use a pattern like '%s/*' or '%s/**' to upload directory contents", source, source, source) | ||
| } | ||
| return true | ||
| } | ||
| return false | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
When count > 1 (directory has glob-expanded children), the new code returns nil, and the caller will attempt to upload the directory itself. that will fail at os.Open or S3's PutObject. old code always skipped directories. we need to either:
- Return (skip bool, err error) so caller can continue for directories with children
- Or add a sentinel error like errSkipDirectory that the caller handles with continue
Author
There was a problem hiding this comment.
Returned errSkip here so caller can continue for directories with children
… in os.Stat(source) and also handle the case of directory with blob pattern
Ompragash
approved these changes
Jan 12, 2026
Member
Ompragash
left a comment
Ompragash
left a comment
There was a problem hiding this comment.
Fixes the bug, preserves original behavior, cross-platform tests, clean pattern so LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pload