-
Notifications
You must be signed in to change notification settings - Fork 68
feat: [CI-18487]: Glob pattern support for PLUGIN_STRIP_PREFIX #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ompragash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
add tests for windows/backslash inputs with validation. add a test that mimics
Exec() validation on windows-style patterns ensuring normalization/anchoring works as intended -
update readme to show wildcard examples and clarify trailing
/meaning -
add a log to show what would be stripped in dryrun mode
-
also log once when no path matches the strip pattern
…olute-path join in resolveKey, added logs and tests.
|
This breaks existing use with relative paths like |
drone-plugins#196)" This reverts commit dfb0035.
|
Thanks, @silverwind, for pointing this out! These changes have been reverted, and they'll be fixed in the next iteration. |
Enhanced
PLUGIN_STRIP_PREFIXwith Glob-Aware Wildcard SupportThis PR enhances the
PLUGIN_STRIP_PREFIXfunctionality by adding wildcard pattern support, allowing dynamic path stripping without relying on shell scripting.Key Features
Wildcard Patterns: Supports
*,**, and?for flexible path matchingBackward Compatible: Existing literal path prefixes continue to work as-is
Robust Validation: Comprehensive checks ensure invalid patterns are rejected gracefully
Added Unit Tests to test the working for all types of glob paths.
🔧 Wildcard Syntax
Testing Link: url



For the above testing correct directories were created: