Allow creating/updating the release discussion category #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
force-pushed
the
feature/release-discussions
branch
from
84ef678 to
e0e6271
Compare
This was referenced Jan 31, 2022
donny-dont
force-pushed
the
feature/release-discussions
branch
from
e0e6271 to
d98745d
Compare
donny-dont
approved these changes
May 9, 2022
Contributor
donny-dont
left a comment
donny-dont
left a comment
There was a problem hiding this comment.
Rebased this so its good to go. @iwilltry42 do you want to take this for a spin before I merge it?
Contributor
Author
|
Hi @donny-dont , thanks for the review! Unfortunately since my project became independent, it's no longer using DroneCI, so I cannot easily test it there. |
- bump GitHub dep to v35.3.0 as this was introduced in v35.1.0 - add new string flag "discussion-category" (+ env vars) - update release: only set category, if not set - NOTE: Currently it looks like release drafts with discussion category set do not "persist" the category when being released, so when publishing a release draft, without explicitly setting the category, it won't have a release discussion. Nothing we can do here I suppose. Signed-off-by: Thorsten Klein <[email protected]>
donny-dont
force-pushed
the
feature/release-discussions
branch
from
d98745d to
f50cd0c
Compare
donny-dont
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit ce75483.
donny-dont
added a commit
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds release discussions to the plugin.
Commit Message:
set do not "persist" the category when being released, so when
publishing a release draft, without explicitly setting the category, it
won't have a release discussion. Nothing we can do here I suppose.