ci-3011 - GAR support #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
suggested changes
Sep 20, 2023
cmd/drone-gcr/main.go
Outdated
| registry = "gcr.io" | ||
| case "GAR": | ||
| if location == "" { | ||
| logrus.Fatalf("Error: For GAR, LOCATION must be set") |
There was a problem hiding this comment.
can you change the error message to,
"Error: For REGISTRY_TYPE of GAR, LOCATION must be set"
and squash your commits.
Contributor
Author
There was a problem hiding this comment.
done and I'll squash on merge :)
There was a problem hiding this comment.
@eoinmcafee00 you didnt push. no change yet
Contributor
Author
There was a problem hiding this comment.
tphoney
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.