feat: [CI-16595]: Added new input PLUGIN_BUILDX_OPTIONS #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavharness
approved these changes
Mar 13, 2025
Ompragash
approved these changes
Mar 13, 2025
Contributor
Author
VIDEO-2025-03-13-15-48-36.mp4 |
Ompragash
changed the title
Ompragash
approved these changes
Mar 14, 2025
| HarnessSelfHostedS3AccessKey: c.String("harness-self-hosted-s3-access-key"), | ||
| HarnessSelfHostedS3SecretKey: c.String("harness-self-hosted-s3-secret-key"), | ||
| HarnessSelfHostedGcpJsonKey: c.String("harness-self-hosted-gcp-json-key"), | ||
| BuildxOptions: c.StringSlice("buildx-options"), |
Collaborator
There was a problem hiding this comment.
Is this comma separated list? Can you please add a comment on how to use this option. Also please add to README as an example.
https://github.com/drone-plugins/drone-buildx#using-docker-buildkit-secrets
| } | ||
| if len(build.BuildxOptions) > 0 { | ||
| args = append(args, build.BuildxOptions...) | ||
| } |
Collaborator
There was a problem hiding this comment.
Please add Unit Tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new input PLUGIN_BUILDX_OPTIONS to pass any supported options to buildx command.
Tested the changes locally:
