Skip to content

fix:[CI-13562]:improve error message for anonymous connector used #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rutvijmehta-harness merged 4 commits into from
Jul 23, 2024
Merged

fix:[CI-13562]:improve error message for anonymous connector used #34

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a82b0ca
fix:[CI-12799]:improve error message for anonymous connector used
Aishwarya-Lad Jul 22, 2024
50a55b8
fix:[CI-13562]:improve error message for anonymous connector used
Aishwarya-Lad Jul 22, 2024
fff4ecd
fix:[CI-13562]: add error in command login too
Aishwarya-Lad Jul 22, 2024
a4ec53c
check for registry empty
Aishwarya-Lad Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/docker/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ func (c *Config) CreateDockerConfigJson(credentials []RegistryCredentials) ([]by
if cred.Registry != "" {

if cred.Username == "" {
return nil, fmt.Errorf("Username must be specified for registry: %s", cred.Registry)
return nil, fmt.Errorf("Username cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")
}
if cred.Password == "" {
return nil, fmt.Errorf("Password must be specified for registry: %s", cred.Registry)
return nil, fmt.Errorf("Password cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")
}
c.SetAuth(cred.Registry, cred.Username, cred.Password)
}
Expand Down