Skip to content

Conversation

@Aishwarya-Lad
Copy link
Contributor

@Aishwarya-Lad Aishwarya-Lad commented Jul 12, 2024

Change the login to docker login command instead of using the Config struct for OIDC changes.
Made the decision to use login instead of writing file directly.
Why the change was made - The login function integrates with various credential helpers, it also handles different registry specific logic in a better way, as opposed to config write where different registries need to be addressed differently.
It handles any changes in the authentication process across different Docker versions.

What is tested- GCR/ECR/ACR build and push steps with DLC
https://docs.google.com/document/d/1dzLf7PR43NiTjdScxu5gUgWO8O3QTonaDupSDIivFuU/edit

@jamie-harness jamie-harness merged commit 68fd0a6 into drone-plugins:master Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants