Skip to content

Conversation

@abhay084
Copy link
Collaborator

@abhay084 abhay084 commented Apr 22, 2024

Screenshot 2024-04-23 at 6 40 27 PM

This change is required because we are referencing this repo function to authenticate in the following repo: "drone-buildx-gcr".

Password: c.String("docker.password"),
Email: c.String("docker.email"),
Config: c.String("docker.config"),
AccessToken: c.String("access-token"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used in this plugin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is being used by the repo (https://github.com/drone-plugins/drone-buildx-gcr). for login and authentication purpose

Copy link
Collaborator

@Sapa96 Sapa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhay084 abhay084 requested a review from Sapa96 April 25, 2024 07:33
@harshjain12 harshjain12 merged commit 1d29de3 into master Apr 29, 2024
@delete-merged-branch delete-merged-branch bot deleted the CI-12041 branch April 29, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants