Add a no-galaxy-force option #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
reviewed
Feb 10, 2021
main.go
Outdated
| Usage: "prepend paths to module library", | ||
| EnvVar: "PLUGIN_MODULE_PATH", | ||
| }, | ||
| cli.BoolFlag{ |
Contributor
There was a problem hiding this comment.
- cli.BoolFlag{
- Name: "no-galaxy-force",
- Usage: "don't force overwriting an existing role or collection",
- EnvVar: "NO_GALAXY_FORCE",
+ cli.BoolTFlag{
+ Name: "galaxy-force",
+ Usage: "don't force overwriting an existing role or collection",
+ EnvVar: "PLUGIN_GALAXY_FORCE",
main.go
Outdated
| Tags: c.String("tags"), | ||
| ExtraVars: c.StringSlice("extra-vars"), | ||
| ModulePath: c.StringSlice("module-path"), | ||
| NoGalaxyForce: c.Bool("no-galaxy-force"), |
Contributor
There was a problem hiding this comment.
GalaxyForce and galaxy-force
plugin.go
Outdated
| Tags string | ||
| ExtraVars []string | ||
| ModulePath []string | ||
| NoGalaxyForce bool |
plugin.go
Outdated
| "--force", | ||
| } | ||
|
|
||
| if p.Config.NoGalaxyForce == false { |
Contributor
Author
|
I forgot the |
Contributor
|
BoolTFlag defaults to true. |
Contributor
Author
|
My bad. I fixed it. |
techknowlogick
approved these changes
Feb 10, 2021
Contributor
Author
|
The CI reached docker hub pull rate limit but it should be fine now (11h later). If someone with the appropriate permissions could restart the build to get this merged. |
Contributor
|
CI fail is fine as like you said it is due to docker hub rate limits, the other tests pass. Although if you want to trigger a build you could send an empty commit. |
tboerger
reviewed
Feb 12, 2021
tboerger
approved these changes
Feb 12, 2021
Contributor
|
Thanks for you effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43.
This add the possibility to remove the
--forcetag during galaxy install. The end goal is to allow caching of galaxy packages.