Skip to content

Refactor SessionTracker and SessionManager into a single class #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

bhouston
Copy link
Member

Description

This PR addresses issue #372 by merging SessionTracker and SessionManager into a single class and converting BrowserDetector to a functional approach.

Changes

  1. Merged SessionTracker and SessionManager into a single SessionTracker class

    • Moved appropriate functionality from SessionManager into SessionTracker
    • Maintained backward compatibility with existing code
    • Simplified the API and eliminated redundant abstractions
  2. Converted BrowserDetector class to a functional approach

    • Replaced the static class with standalone functions
    • Inlined the browser detection functions into SessionTracker for simplicity
  3. Updated all references and tests to use the new implementation

Testing

  • All existing tests pass
  • Browser functionality works as expected

Related Issues

Closes #372

@bhouston bhouston merged commit dce3a8a into main Mar 25, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor SessionTracker and SessionManager into a single class
1 participant