fix: update Ollama provider to use official npm package API correctly #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# [mycoder-agent-v1.2.0](mycoder-agent-v1.1.0...mycoder-agent-v1.2.0) (2025-03-12) ### Bug Fixes * Fix TypeScript errors in MCP implementation ([f5837d3](f5837d3)) ### Features * Add basic Model Context Protocol (MCP) support ([8ec9619](8ec9619)) * **agent:** implement incremental resource cleanup for agent lifecycle ([576436e](576436e)), closes [#236](#236) * background tools is now scope to agents ([e55817f](e55817f))
# [mycoder-v1.2.0](mycoder-v1.1.1...mycoder-v1.2.0) (2025-03-12) ### Features * Add basic Model Context Protocol (MCP) support ([8ec9619](8ec9619)) * **agent:** implement incremental resource cleanup for agent lifecycle ([576436e](576436e)), closes [#236](#236) * background tools is now scope to agents ([e55817f](e55817f))
# [mycoder-agent-v1.3.0](mycoder-agent-v1.2.0...mycoder-agent-v1.3.0) (2025-03-12) ### Features * implement MCP tools support ([2d99ac8](2d99ac8))
# [mycoder-v1.3.0](mycoder-v1.2.0...mycoder-v1.3.0) (2025-03-12) ### Features * implement MCP tools support ([2d99ac8](2d99ac8))
|
🎉 This PR is included in version mycoder-agent-v1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version mycoder-v1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Ollama Provider Implementation
This PR updates the OllamaProvider class to properly use the official Ollama npm package API. The previous implementation had some TypeScript errors and didn't fully match the Ollama package's expected formats.
Changes Made:
Tooltype from the Ollama packageconvertFunctionsToToolsmethod to transform our FunctionDefinition format to Ollama's Tool formatprocessToolCallsmethod to correctly extract tool calls from Ollama's response formatanywith more specific typesTesting:
The implementation has been tested with various models and works correctly with:
Fixes #246