Nour/mm oracle #1738
Open
Nour/mm oracle #1738
+1,455
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jordy25519 <[email protected]>
* add offset * working tests * refactor to use MM oracle as its own type * remove weird preface * sdk updates * bankrun tests all pass * fix test * changes and fixes * widen confidence if mm oracle too diff * sdk side for confidence adjust
crispheaney
reviewed
Jul 18, 2025
| msg!( | ||
| "zeroed amm fields for perp market {}", | ||
| perp_market.market_index | ||
| pub fn handle_update_mm_oracle( |
There was a problem hiding this comment.
why do you need this and handle_update_mm_oracle_native?
There was a problem hiding this comment.
just leaving the anchor func as a fallback. we can delete if you want
| } | ||
| } | ||
|
|
||
| pub fn get_confidence(&self) -> DriftResult<u64> { |
There was a problem hiding this comment.
why this vs having mm oracle post confidence?
There was a problem hiding this comment.
we dont have the open slots on the amm right now
0xbigz
reviewed
Jul 21, 2025
| } | ||
| } | ||
|
|
||
| pub fn get_delay(&self) -> i64 { |
There was a problem hiding this comment.
should this and confidence be same functions so you choose consistent/correct value for both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.