storage: stop proxy health checker on shutdown - #1990
Merged
Zephyrcf merged 1 commit intoJul 22, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves storage’s proxy health-check lifecycle by ensuring the background health-check thread is woken and exits promptly when a Connection is shut down or dropped, preventing the worker from holding proxy resources until the next health-check interval.
Changes:
- Introduce a stop/wakeup mechanism (
HealthCheckerStop) to interrupt the proxy health-check thread’s sleep. - Signal the health-check thread to stop on
Connection::shutdown()and also inDrop for Connection. - Add unit tests asserting the health-check worker releases its
Proxyreference on shutdown and drop.
Collaborator
|
Thanks, LGTM! plz add SOB for the commit. :) |
Park-Jiyeonn
force-pushed
the
fix/stop-proxy-health-checker
branch
from
July 22, 2026 08:51
1221d60 to
96281c2
Compare
Member
|
@Park-Jiyeonn plz squash the commits. |
Wake the proxy health-check worker when its connection is shut down or dropped. This prevents the worker from retaining proxy resources and waiting for the full health-check interval after the connection is gone. Signed-off-by: Park.Jiyeon <jiyeonnn2@icloud.com>
Park-Jiyeonn
force-pushed
the
fix/stop-proxy-health-checker
branch
from
July 22, 2026 09:51
96281c2 to
4509b07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Wake the proxy health-check worker when its connection is shut down or dropped. This prevents the worker from retaining proxy resources and waiting for the full health-check interval after the connection is gone.
Change Type
Please select the type of change your pull request relates to: