fix: avoid logger deadlock on broken error channel - #1964
Merged
Zephyrcf merged 1 commit intoJun 15, 2026
Conversation
Signed-off-by: chengyue <yue.cheng.ted@gmail.com>
tedcy
requested review from
a team,
Desiki-high,
adam3q and
power-more
and removed request for
a team
June 15, 2026 10:28
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
==========================================
+ Coverage 68.52% 72.76% +4.24%
==========================================
Files 210 210
Lines 63071 63073 +2
Branches 55826 55828 +2
==========================================
+ Hits 43218 45896 +2678
+ Misses 18046 15104 -2942
- Partials 1807 2073 +266
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This bumps
flexi_loggerto0.28.0and tells it not to panic when its own error output channel is broken.That is the path hit in #1958. When cache/log/stdout/stderr are on a full filesystem, a secondary logger error can make
nydusdstop answering the daemon API.Related Issues
Fixes #1958
Change Details
flexi_loggerfrom0.25.6to0.28.0..panic_if_error_channel_is_broken(false)in both nydusd logger setup paths.Test Results
cargo fmt --checkcargo check --locked -p nydus-rscargo test -p nydus-rs logger::tests/api/v1/daemonstill returned while the filesystem was full/api/v1/daemonalso returned after space was freedChange Type
Self-Checklist