Skip to content

ci: pin nerdctl to v2.2.2 to fix smoke test failure - #1947

Merged
BraveY merged 1 commit into
dragonflyoss:masterfrom
Zephyrcf:fix/ci-pin-nerdctl-version
May 29, 2026
Merged

ci: pin nerdctl to v2.2.2 to fix smoke test failure#1947
BraveY merged 1 commit into
dragonflyoss:masterfrom
Zephyrcf:fix/ci-pin-nerdctl-version

Conversation

@Zephyrcf

@Zephyrcf Zephyrcf commented May 26, 2026

Copy link
Copy Markdown
Member

Overview

Fix TestTakeover/TestAPIHotUpgrade smoke test failure by pinning nerdctl to v2.2.2.

Related Issues

Related containerd/nerdctl#4583

Change Details

Since nerdctl v2.3.x, when connected to containerd >= 2.0.0, the image pull logic switches from the legacy client.Pull() to the client.Transfer() API , which requires unpack_config configured in containerd. There is no runtime flag to force the legacy client.Pull() path in v2.3.x.(SupportsFullTransferService)

The script misc/prepare.sh pulls the latest nerdctl version by default. After the upgrade, the smoke test failed with the error: unable to initialize unpacker: no unpack platforms defined: invalid argument
(CI failure)

When testing with nerdctl v2.3.x + containerd 2.x, adding these containerd config entries has been verified to resolve the issue and enable normal operation:

[[plugins.'io.containerd.transfer.v1.local'.unpack_config]]                                                                                                          
    platform = "linux/amd64"                                                                                                                                         
    snapshotter = "nydus"                                                                                                                                            
                                                                                                                                                                     
[proxy_plugins.nydus]                                                                                                                                                
    type = "snapshot"                                                                                                                                                
    address = "/run/containerd-nydus/containerd-nydus-grpc.sock"                                                                                                     
    [proxy_plugins.nydus.exports]                                                                                                                                    
        enable_remote_snapshot_annotations = "true"

Test Results

If you have any relevant screenshots or videos that can help illustrate your changes, please add them here.

Change Type

Please select the type of change your pull request relates to:

  • Bug Fix
  • Feature Addition
  • Documentation Update
  • Code Refactoring
  • Performance Improvement
  • Other (please describe)

Self-Checklist

Before submitting a pull request, please ensure you have completed the following:

  • I have run a code style check and addressed any warnings/errors.
  • I have added appropriate comments to my code (if applicable).
  • I have updated the documentation (if applicable).
  • I have written appropriate unit tests.

@Zephyrcf
Zephyrcf requested review from a team, Desiki-high, adam3q and power-more and removed request for a team May 26, 2026 18:47
@Zephyrcf
Zephyrcf force-pushed the fix/ci-pin-nerdctl-version branch from 779476d to ca13be2 Compare May 26, 2026 18:49
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.68%. Comparing base (eb725d1) to head (ca13be2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
+ Coverage   68.40%   72.68%   +4.27%     
==========================================
  Files         210      210              
  Lines       62747    62747              
  Branches    55524    55524              
==========================================
+ Hits        42921    45605    +2684     
+ Misses      18032    15083    -2949     
- Partials     1794     2059     +265     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BraveY

BraveY commented May 29, 2026

Copy link
Copy Markdown
Contributor

Can we modify the configuration used to adapt to this latest version? I'm concerned that pinning the version may mask more issues over time.

@Zephyrcf

Copy link
Copy Markdown
Member Author

Can we modify the configuration used to adapt to this latest version? I'm concerned that pinning the version may mask more issues over time.

Agreed. Let's update the config instead of pinning.

@Zephyrcf
Zephyrcf force-pushed the fix/ci-pin-nerdctl-version branch from ca13be2 to bb765de Compare May 29, 2026 05:00
Signed-off-by: Zephyr <zinsist777@gmail.com>
@Zephyrcf
Zephyrcf force-pushed the fix/ci-pin-nerdctl-version branch from bb765de to 9199c97 Compare May 29, 2026 05:57
@BraveY

BraveY commented May 29, 2026

Copy link
Copy Markdown
Contributor

LGTM

@BraveY
BraveY merged commit f0189d1 into dragonflyoss:master May 29, 2026
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants