converter: fix plain HTTP in conversion - #1749
Merged
Merged
Conversation
We should just use plain http when user sets the option. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
bergwolf
requested review from
a team,
changweige,
gaius-qi and
imeoer
and removed request for
a team
September 1, 2025 11:33
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
- Coverage 55.56% 55.55% -0.01%
==========================================
Files 197 197
Lines 53108 53111 +3
Branches 44443 44443
==========================================
- Hits 29508 29506 -2
- Misses 22131 22135 +4
- Partials 1469 1470 +1
🚀 New features to boost your workflow:
|
Zephyrcf
approved these changes
Sep 1, 2025
Zephyrcf
left a comment
Member
There was a problem hiding this comment.
LGTM! I will check the failed ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should just use plain http when user sets the option.
Before fix:
After fix: