Skip to content

fix: JSON export region_id type consistency#957

Merged
dr5hn merged 1 commit into
dr5hn:masterfrom
gschaer:master
Mar 4, 2025
Merged

fix: JSON export region_id type consistency#957
dr5hn merged 1 commit into
dr5hn:masterfrom
gschaer:master

Conversation

@gschaer

@gschaer gschaer commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Fixes #956 by making sure that the 'region_id' is stored as an int (consistent with other ids and data model).

This will ensure that the region_id in the json and yaml exports of the subregions is an int.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working exports labels Feb 12, 2025

@pandurangareddy pandurangareddy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code can be committed and it's out put is working.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2025
@dr5hn dr5hn merged commit 36cea8b into dr5hn:master Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working exports lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect region_id datatype in json/subregions.json

3 participants