fix(countries): normalise postal_code_format alternative-separator (BM, TW)#1537
Merged
Conversation
… | (BM, TW) The convention used by GB/GG/IM/JE/BH/IR/LB/NL/PY/SH/AU-territories is to separate alternative postal code formats with the pipe character. Two outliers used non-standard separators: BM '@@ ## or @@ @@' -> '@@ ##|@@ @@' TW '###/#####/######' -> '###|#####|######' Pure-cosmetic — neither postal_code_regex changes, no postcode rows touched, no FK or geometry impact. This makes downstream postal-format parsers (e.g. csc-validator) consistent across all 13 multi-format countries. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
CSC Validation ReportPR Format
Labels applied: Schema Validation (250 records)Errors (blocking):
Warnings:
Duplicate Detection
❌ 1000 error(s), 1500 warning(s) | Status: Changes required Please fix the errors above and push a new commit. Refer to our Contribution Guidelines for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convention used by 11 multi-format countries (GB/GG/IM/JE/BH/IR/LB/NL/PY/SH and AU-territory mirrors) is to separate alternative postal code formats with the pipe character
|. Two outliers used non-standard separators:@@ ## or @@ @@@@ ##|@@ @@###/#####/#########|#####|######Pure-cosmetic.
postal_code_regexis unchanged for both, and no postcode rows are touched — only the human-readable format hint normalises to the existing convention.Why it matters: downstream postal-format parsers (e.g. csc-validator, the export tool's postcode preview) iterate
format.split('|')to render alternatives. The non-pipe forms produce garbled previews.