fix(timezones): correct 72 city rows with foreign IANA zones (#1085 follow-up)#1535
Merged
Conversation
…ollow-up) Sweeps the residual scope from #1085 — city rows whose timezone field points at a neighbouring country's zone instead of the correct local zone. VN 63 Asia/Bangkok -> Asia/Ho_Chi_Minh PS 6 Asia/Jerusalem -> Asia/Hebron (West Bank governates) UZ 2 Asia/Bishkek -> Asia/Tashkent (Fergana Region) ID 1 Asia/Ho_Chi_Minh -> Asia/Pontianak (Sambas, KB) TF/Tromelin (disputed admin) and FR/Nouméa (correct for state NC) excluded. Idempotent fix script under bin/scripts/fixes/. Summary in .github/fixes-docs/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
size:M
Owner
Author
|
Re-running validator with Source link added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the residual scope from #1085. The original issue called out a handful of countries (ES, RO) where city timezone fields pointed at the wrong IANA zone. Master is clean for those — this PR sweeps every remaining city row whose timezone points at a neighbouring country's zone.
Source: IANA Time Zone Database (tzdata) — canonical zone-to-territory mapping. Cross-checked against Wikipedia: List of tz database time zones.
Scope (72 rows across 4 files)
cities/VN.jsonAsia/BangkokAsia/Ho_Chi_Minhcities/PS.jsonAsia/JerusalemAsia/Hebroncities/UZ.jsonAsia/BishkekAsia/Tashkentcities/ID.jsonAsia/Ho_Chi_MinhAsia/PontianakPer-row reasoning in
.github/fixes-docs/FIX_1085_FOREIGN_TIMEZONES_SUMMARY.md. All 6 PS rows are West Bank governates (BTH/HBN/JEM/SLT) — Gaza Strip would map toAsia/Gaza, none qualified. Both UZ rows are in Fergana Region (eastern UZ).Out of scope
Indian/Reunion) — disputed admin, left untouched.Pacific/Noumea) — correct for state_code NC overseas.Verification
After-counts: 0 rows still tagged with the wrong zone in any of the 4 files. Only the
timezonetext field changes — no FK or coordinate changes.Closes #1085 follow-up.