fix(ES): drop 22 admin-level placeholder rows from cities (#1498)#1516
Merged
Conversation
Drops 22 placeholder records from contributions/cities/ES.json:
- 21 "Provincia de X" / "Província de X" rows (ids 36362, 36364, 36365,
36373, 36375, 36376, 36377, 36379, 36381, 36383, 36385, 36386, 36387,
36389, 36390, 36391, 36392, 36393, 36394, 36396, 36400). Spanish
provinces are already represented as proper states in states.json,
making these pseudo-cities duplicate concepts. Their own state_code
values are inconsistent (e.g. "Provincia de Burgos" parented under
state_code=LE), confirming stub-data status.
- 1 cross-state Alicante stub (id 32244, state_code=V) flagged by the
reporter as a cross-province leak in Valencia's city list. Canonical
row is id 152158 ("Alicante/Alacant", state_code=A).
Counts: 8,427 -> 8,405 rows. Out-of-bounds coordinate violations drop
from 129 to 127 (the dropped stubs included 2 invalid coords). 0 schema
errors, 0 cross-reference errors, same-name <5km duplicate pairs
unchanged at 45 (all pre-existing).
Refs #1498. Does not close it -- PR-B follow-up retags ~6,920 mistyped
admin-level rows to type=city.
dosubot
Bot
added
the
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1498.
Drops 22 admin-level placeholder rows from
contributions/cities/ES.json:states.jsonalready lists the 50 provinces as proper states, so these pseudo-cities are duplicate concepts. Their ownstate_codevalues are inconsistent (e.g. "Provincia de Burgos" parented underLE/León, "Provincia de Zaragoza" underHU/Huesca), confirming stub-data status.Alicante,state_code=V) — exactly the cross-province leak the reporter flagged. The canonical Alicante row is id 152158 (Alicante/Alacant,state_code=A) under the proper Alicante province.ES.jsonrowsProvincia */Província *rowsImplementation
bin/scripts/fixes/spain_drop_provincia_placeholders.py— explicit id allowlist + per-id name/state verification. Refuses to drop rows whose name or state has shifted from what was audited. Idempotent.Validation
state_idresolves to an ES state andstate_codematches the resolved state'siso2.TF,GC), pre-existing, same pattern as IT/Lampedusa in feat(IT): remap cities to metropolitan cities and provinces (#1349) #1395.python3 -m json.toolparses cleanly;normalize_json.pyis a no-op.Scope
states.jsonorcountries.json.adm1/adm2/adm3→city) and will close the issue.Fix details in
.github/fixes-docs/FIX_1498_PR_A_SUMMARY.md.