Skip to content

fix(IT): merge 2 dedup pairs flagged by #1395 remap (#1349 follow-up)#1481

Merged
dr5hn merged 1 commit into
masterfrom
fix/it-merge-dedup-pairs-1349
Apr 27, 2026
Merged

fix(IT): merge 2 dedup pairs flagged by #1395 remap (#1349 follow-up)#1481
dr5hn merged 1 commit into
masterfrom
fix/it-merge-dedup-pairs-1349

Conversation

@dr5hn
Copy link
Copy Markdown
Owner

@dr5hn dr5hn commented Apr 27, 2026

Summary

Resolves the two duplicate pairs explicitly deferred by PR #1479 because neither half carried the modern ISTAT-canonical merged-comune name. Both merges happened on 2017-01-01 under regional law and have new post-merger Wikidata items.

Pair MN (state_code=MN)

  • Renamed id 60744 SermideSermide e Felonica (name + native)
  • Set wikiDataId to Q39681 (canonical merged-comune item; was null)
  • Dropped id 138474 Felonica (absorbed into the merger; Q42389 retained on Wikidata as historical-comune entity)

Pair PV (state_code=PV)

  • Renamed id 138065 CorteolonaCorteolona e Genzone (name + native)
  • Set wikiDataId to Q3702780 (canonical merged-comune item; was Q40346 for the legacy Corteolona-only entity)
  • Dropped id 138905 Genzone (absorbed; Q39697 retained on Wikidata as historical-comune entity)

Counts

  • contributions/cities/IT.json: 9,941 → 9,939 rows (−2, as expected)

Notes

Test plan

  • PR validator passes (schema, cross-ref, coordinates, duplicates, source URLs)
  • Round-trip JSON → MySQL → JSON matches
  • No remaining rows with name in {Sermide, Felonica, Corteolona, Genzone} in IT.json

🤖 Generated with Claude Code

PR #1479 deferred these two merged-comune pairs because neither half
carried the modern ISTAT-canonical name. Resolves them now:

- Pair MN: rename id 60744 'Sermide' → 'Sermide e Felonica'
  (native + name); set wikiDataId Q39681; drop id 138474 'Felonica'.
- Pair PV: rename id 138065 'Corteolona' → 'Corteolona e Genzone'
  (native + name); set wikiDataId Q3702780; drop id 138905 'Genzone'.

Row count: 9941 → 9939. Refs #1349, #1479.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 27, 2026 15:11
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2026
@dosubot dosubot Bot added the fixed Issue has been fixed label Apr 27, 2026
@dr5hn dr5hn merged commit a95f2fb into master Apr 27, 2026
2 of 3 checks passed
@dr5hn dr5hn deleted the fix/it-merge-dedup-pairs-1349 branch April 27, 2026 15:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up data cleanup for Italy city contributions to resolve two remaining duplicate comune pairs previously deferred, by renaming the kept records to the ISTAT-canonical merged-comune names and removing the absorbed duplicates.

Changes:

  • Rename city id 60744 to Sermide e Felonica and set wikiDataId to Q39681; remove duplicate city id 138474 (Felonica).
  • Rename city id 138065 to Corteolona e Genzone and change wikiDataId to Q3702780; remove duplicate city id 138905 (Genzone).
Comments suppressed due to low confidence (2)

contributions/cities/IT.json:104189

  • After renaming this city to "Sermide e Felonica", the translations block still contains the old name (e.g., it, en-equivalents, etc. are still "Sermide"). This makes the record internally inconsistent and will surface incorrect localized names to consumers. Please update the translations to the merged comune name (or remove entries you can't confidently translate).
    contributions/cities/IT.json:283441
  • This record is renamed to "Corteolona e Genzone", but the translations values are still for the pre-merge name "Corteolona" (including the Italian it translation). This introduces incorrect localized output for the merged comune. Please update translations to the merged name (or remove any languages you cannot verify).

dr5hn added a commit that referenced this pull request Apr 27, 2026
…g, postcodes (#1491)

Adds:
- v3.2 release section summarising today's work (#1349, #1352, #1039,
  #1481-#1490).
- Notable callout for FR mainland city region->department remap
  (mirrors the existing IT one), explicitly calling out the behaviour
  change for consumers querying by region state_code.
- Chronological entries for each of the 19 PRs that landed today
  (changelog automation only runs weekly).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:cities fixed Issue has been fixed large-contribution size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Italy seems to be totally wrong

2 participants